Optimize for topk=1 case if we do not handle duplicates #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssarkar2 please fix formatting |
ssarkar2
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski and
mgawarkiewicz
as code owners
done |
michalkuligowski
force-pushed
the
sarkar/topk1_ignoreduplicates_optimized
branch
from
91c1dfe to
c6023de
Compare
michalkuligowski
force-pushed
the
sarkar/topk1_ignoreduplicates_optimized
branch
from
c6023de to
4381b16
Compare
michalkuligowski
force-pushed
the
sarkar/topk1_ignoreduplicates_optimized
branch
from
4381b16 to
be5f32b
Compare
michalkuligowski
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original : #599
We have a case where topk=1, and topp=<1.
Adding special handling for the case topk=1 and handle_duplicate=0 (by default handle_duplicate=0, to support num-scheduling-steps)